Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some small cleanups to launch #759

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Some small cleanups to launch #759

merged 2 commits into from
Feb 13, 2024

Conversation

clalancette
Copy link
Contributor

  1. Cleanup some type annotations. In particular, use the inline style of type annotations, rather than the comments, as this is what we do everywhere else. It will also make newer versions of mypy happier.
  2. Change the pytest markers tryfirst/trylast to using hookimpl, since the former are deprecated and throw warnings on newer versions of pytest.

@clalancette
Cleanup some type annotations.
3d8e77f 
Certain versions of mypy complain that these annotations
are not being used, since the annotations are only in
comments.  But we use the "inline" types everywhere else,
so switch this over to the same thing, which should remove
the warning.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Switch tryfirst/trylast to hookimpl.
8f68152 
tryfirst and trylast are deprecated in newer versions
of pytest, so use the hookimpl here.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Feb 13, 2024
View reviewed changes
Copy link

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@clalancette clalancette merged commit d9ffd80 into rolling Feb 13, 2024
3 checks passed
@clalancette clalancette deleted the clalancette/cleanups branch February 13, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

@methylDragon methylDragon Awaiting requested review from methylDragon

@wjwwood wjwwood Awaiting requested review from wjwwood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clalancette @mjcarroll @fujitatomoya